sippy / rtpproxy / 989

86%

master: 91%

Pull #91

travis-ci

libucl/Makefile.am: set define _BSD_SOURCE

ucl_util.c includes <limits.h>, but the latter does not always provide PATH_MAX
automatically. For instance on musl at least one of

_POSIX_SOURCE
_POSIX_C_SOURCE
_XOPEN_SOURCE
_GNU_SOURCE
_BSD_SOURCE

needs to be defined for the defines to be turned on. When that is not the case
the compile breaks like shown below. To fix this define _BSD_SOURCE when
building lubucl. _BSD_SOURCE was chosen because rtpproxy has a BSD license and
libucl doesn't reference _BSD_SOURCE at all.

../external/libucl/src/ucl_util.c: In function 'ucl_include_url':
../external/libucl/src/ucl_util.c:914:14: error: 'PATH_MAX' undeclared (first use in this function); did you mean 'INT8_MAX'?
  char urlbuf[PATH_MAX];
              ^~~~~~~~
              INT8_MAX
../external/libucl/src/ucl_util.c:914:14: note: each undeclared identifier is reported only once for each function it appears in
../external/libucl/src/ucl_util.c: In function 'ucl_include_file_single':
../external/libucl/src/ucl_util.c:987:15: error: 'PATH_MAX' undeclared (first use in this function); did you mean 'INT8_MAX'?
  char filebuf[PATH_MAX], realbuf[PATH_MAX];
               ^~~~~~~~
               INT8_MAX
../external/libucl/src/ucl_util.c:188:22: warning: implicit declaration of function 'realpath'; did you mean 'realloc'? [-Wimplicit-function-declaration]
 #define ucl_realpath realpath
                      ^
../external/libucl/src/ucl_util.c:996:6: note: in expansion of macro 'ucl_realpath'
  if (ucl_realpath (filebuf, realbuf) == NULL) {
      ^~~~~~~~~~~~
../external/libucl/src/ucl_util.c:1059:21: warning: implicit declaration of function 'strdup'; did you mean 'strcmp'? [-Wimplicit-function-declaration]
  parser->cur_file = strdup (realbuf);
                     ^~~~~~
                     strcmp
../external/libucl/src/ucl_util.c: In function 'ucl_include_file':
../external/libucl/src/ucl_util.c:1314:20: error: 'PATH_MAX' undeclared (first use in this function); ... (continued)

1 of 1 new or added line in 1 file covered. (100.0%)

8254 of 9551 relevant lines covered (86.42%)

4330384.27 hits per line