ctmarinas / stgit / 64

90%

push

travis-ci

Replace readonly_constant_property decorator

The custom readonly_constant_property decorator was only used within the
Directory class hierarchy. And it no longer seems to warrant its
complexity.

The git_dir readonly_constant_property becomes a regular _get_git_dir()
method. It is only ever called once, at Directory setup time, to ensure
that the command is being run in the context of a git repository.

The __topdir_path readonly_constant_property is removed. The cd_to_topdir()
method now calls `git rev-parse --show-cdup` on its own and changes
directory, if necessary. This potentially saves a superfluous os.chdir()
call.

The is_inside_git_dir readonly_constant_property was unused and is removed.

Signed-off-by: Peter Grayson <pete@jpgrayson.net>

2228 of 2797 branches covered (79.66%)

Branch coverage included in aggregate %.

6491 of 7393 relevant lines covered (87.8%)

1.75 hits per line