540
73%

Ran 23 Sep 2019 07:53AM UTC

Jobs 5

Files 129

Run time 2min

Badge

Embed ▾

pending completion

Build # 540

Build Type

cron

travis-ci

Committed by

jcchavezs

Commit Message

Fix HTTP reporter potential unbounded goroutine creation (#146)

* Fix HTTP reporter potential unbounded goroutine creation

Currently the HTTP reporter spawns a new goroutine each time a new batch needs
to be sent to the server. Execution of those goroutines gets serialized through
the `sendMtx`.

This behavior is problematic when the zipkin server is down and leads to
creation of unbounded number of goroutines each of which will wait for its turn
on the `sendMtx` and then fail.

Fix this by creating one send goroutine to handle sending data to the server.
This also removes the need for the `sendMtx` since `sendBatch` will only be
called by the send goroutine.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

* Add more HTTP reporter test cases

Add HTTP reporter test cases for BatchInterval() and BatchSize() options
behavior.

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Run Details

4911 of 7501 relevant lines covered (65.47%)

23398.16 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	540.1	23 Sep 2019 07:55AM UTC	75.43	Travis Job 540.1
2	540.2	23 Sep 2019 07:53AM UTC	81.46	Travis Job 540.2
3	540.3 (GO111MODULE=on)	23 Sep 2019 07:53AM UTC	60.65	Travis Job 540.3
4	540.4 (GO111MODULE=on)	23 Sep 2019 07:53AM UTC	60.65	Travis Job 540.4
5	540.5 (GO111MODULE=on)	23 Sep 2019 07:56AM UTC	60.65	Travis Job 540.5

Source Files on build 540

Detailed source file information is not available for this build.

openzipkin / zipkin-go / 540
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 540

openzipkin / zipkin-go / 540 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 540

openzipkin / zipkin-go / 540
73%

README BADGES
x