gap-system / gap / 10667

4%

push

travis-ci

Refactor the 'classical' random number generator

So far, the old random number generator using a single global state in the
global variables `R_N` and `R_X` was still present in the GAP library, and was
used to power the `GlobalRandomSource`. In addition, there was a type
`IsGAPRandomSource` of random sources, which also emulated the way the old RNG
worked.

This PR removes the old RNG, and replaces the `GlobalRandomSource` by one of
type `IsGAPRandomSource`. The undocumented function `RANDOM_LIST` is also
removed (no distributed package uses it). To ensure backwards compatibility,
we provide an implementation of `RANDOM_SEED` which uses `GlobalRandomSource`
(only two packages, `recog` and `gbnp`, call `RANDOM_SEED`, and only in their
package tests). Finally, dummies for `R_N` and `R_X` are retained to help
detect any ancient internal code people might throw at GAP.

27 of 28 new or added lines in 3 files covered. (96.43%)

285191 of 337792 relevant lines covered (84.43%)

28108947.69 hits per line