netceteragroup / react-message-source / 81

96%

push

travis-ci

[NO-ISSUE] Fixed issue with FetchingProvider remounting children (#14)

* There was an issue with FetchingProvider that it rendered it's
children initially, before fetching was started, then rendering null and
finally rendering children again after fetching. This happened when
blocking was set to true (which is default). This was causing multiple
mounts of children, affecting performance.
* The issue was caused by misuse of "isFetching" flag in rendering logic
since it was initially false, before fetching has even started.
* Replacing "isFetching" with "isFetched" is restoring original purpose
of "blocking" flag, since rendering should or shouldn't be blocked until
data is fetched, not while it is fetching as it was implemented so far.

33 of 37 branches covered (89.19%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

61 of 61 relevant lines covered (100.0%)

7.92 hits per line