4569
81%

Ran 16 Sep 2019 01:42PM UTC

Jobs 2

Files 146

Run time 306min

Badge

Embed ▾

pending completion

Build # 4569

Build Type

push

travis-ci

Committed by

jaimeperez

Commit Message

Do not attempt to set the session ID for transient sessions

It just doesn't make any sense. If we managed to get it from an existing cookie, it serves no purpose, as at this point we couldn't load the session anyway, and what we use to track users is the track ID, not the session ID. Additionally, since this is a transient session, we're not going to push the cookie to the browser (we might not even can do that), so it's really pointless to set the session ID.

This, additionally, was causing that the Session class would be unable to initialize and register a transient session if the issue that forced us to use a transient in the first place was an issue with the session handler (e.g. missing PHP extensions or dependencies, or connection failure to the backend, etc). Under such circumstances, the code removed here will not work either, since the session handler will continue to fail to initialize. This would cause the exception handler to jump in, completely losing control of the execution, and making it impossible to display the error to the user (since the transient session creation is never completed, it cannot be used later where it is needed in the SimpleSAML\Error\Error class).

This resolves #914.

Run Details

4359 of 12430 relevant lines covered (35.07%)

4.2 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4569.1 (COMMAND="install")	16 Sep 2019 01:41PM UTC	0	35.07	Travis Job 4569.1
6	4569.6 (COMMAND="update")	16 Sep 2019 01:44PM UTC	0	35.07	Travis Job 4569.6

Source Files on build 4569

Detailed source file information is not available for this build.

simplesamlphp / simplesamlphp / 4569
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4569

simplesamlphp / simplesamlphp / 4569 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4569

simplesamlphp / simplesamlphp / 4569
81%

README BADGES
x