• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

sagalbot / vue-select / 1097
92%

Build:
DEFAULT BRANCH: master
Ran 13 Sep 2019 07:20PM UTC
Jobs 1
Files 4
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1097

push

travis-ci

sagalbot
Make sure selected value is an option after option changed and react to value property changes even if tracking value internally (#914)

* make sure selected tracked value is an option if possible

Before this case did not work correctly:

- Select was rendered with *no* options, but *with* a saved value
- Options were fetched by ajax and options prop was updated
- Reduce function if passed

What happens without this commit is that the selected tracked value
simply was the raw reduced value (previously saved). Which means that
displaying a label for example does not work if the label comes from the
unreduced option.

This commit makes sure that the internal tracked value is checked
against all options not only once the select is created but additionally
when options change.

* remove useless keys

- first key was always undefined
- second key was always the index which is not usefull at all since it
  changes based on the order

* add test for setting value after option changed

* correctly react to value property changes if tracking internally

fixes sagalbot#855, sagalbot#842

* add getOptionKey prop

* yarn upgrade doc

* add getOptionKey api doc and fix links

* yarn upgrade

* do not use key on slot

* fix label spec

164 of 183 branches covered (89.62%)

16 of 16 new or added lines in 1 file covered. (100.0%)

198 of 207 relevant lines covered (95.65%)

42.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1097.1 13 Sep 2019 07:20PM UTC 0
95.65
Travis Job 1097.1
Source Files on build 1097
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1097
  • ebcdcc5c on github
  • Prev Build on master (#1067)
  • Next Build on master (#1100)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc