curl / curl / 11539

71%

master: 37%

Pull #4345

travis-ci

doh: fix off-by-one error in size check for doh_encode()

When building the outgoing DNS packet, we typically need one byte more
than the length of the host name since each "label" needs a single byte
length. "a.b" needs four bytes.

This would previously lead to a single byte overwrite of the given input
host name was exactly 240 bytes, but the overwritten data is the length
variable that gets updated immediately afterwards, making the net result
that it only made a broken DNS packet.

Inspired-by: Paul Dreik

1 of 1 new or added line in 1 file covered. (100.0%)

3817 of 5339 relevant lines covered (71.49%)

0.0 hits per line