mediaelement / mediaelement / 974

74%

push

travis-ci

Undo changes introduced 4.2.11 to fix unmute bug (#2692)

* Update dash.js - Unmute doesn't work in latest release (4.2.12)

The problem occurs since 4.2.11 with the following fix:

3de44e7#diff-8e5b21e030b4838c834057ce630b535b

====================
IE 11 returns IndexSizeError (4.2.10) or InvalidStateError in the console.
If the user tries via the Left/Right arrow keys to seek a new play position before clicking 'play', there's an error in IE 11, because the time-slider node is not attached to the document. The above commits add a condition that the value 0 will not be overwritten with 0.

src/js/renderers/dash.js#154
src/js/renderers/flv.js#145
src/js/renderers/hls.js#142
src/js/renderers/html5.js#76

Until 'play' is clicked the value is 0, formerly 'NaN'. While playing media the value is the currentTime.
====================

In each case:

if (value > 0) node[propName] = value;

To correct the bug where unmute is broken when the volume value is 0, the code needs to change to:

if (value >= 0) node[propName] = value;

In all 4 files.

However, the tweak reintroduces the original IE11 InvalidStateError console error, so it is best to just revert to:

node[propName] = value;

In all 4 files. Forget about IE.

Changed:

src/js/renderers/dash.js#154
src/js/renderers/flv.js#145
src/js/renderers/hls.js#142
src/js/renderers/html5.js#76

* Update flv.js - Unmute doesn't work in latest release (4.2.12)

The problem occurs since 4.2.11 with the following fix:

3de44e7#diff-8e5b21e030b4838c834057ce630b535b

====================
IE 11 returns IndexSizeError (4.2.10) or InvalidStateError in the console.
If the user tries via the Left/Right arrow keys to seek a new play position before clicking 'play', there's an error in IE 11, because the time-slider node is not attached to the document. The above commits add a condition that the value 0 will not be overwritten with 0.

src/js/renderers/dash.js#154
src/js/ren... (continued)

272 of 713 branches covered (38.15%)

327 of 439 relevant lines covered (74.49%)

6.02 hits per line