sebelga / gstore-node / 485

98%

push

travis-ci

fix(entitykey): remove convertion of string number to integer for entity key id (#179)

The live Datastore treats the same way User.get("123") than User.get(123). Both return the entity with the Key.id being "123". The conversion from string to an integer has been removed inside gstore and let to the consumer to implement if needed.

BREAKING CHANGE: The "keyType" Schema option has been removed as it is no longer needed. Also, as gstore does not parse the id anymore, running your project against the Datastore emulator locally might break as the emulator treats differently User.get(123) than User.get("123"). Auto-allocated ids are integers and need to be provided as integers for the Emulator.

#168

750 of 793 branches covered (94.58%)

1131 of 1162 relevant lines covered (97.33%)

315.76 hits per line