4534
81%

Ran 04 Sep 2019 02:15PM UTC

Jobs 2

Files 146

Run time 2min

Badge

Embed ▾

pending completion

Build # 4534

Build Type

push

travis-ci

Committed by

jaimeperez

Commit Message

Make sure expired data is actually purged

The SimpleSAML\Session::expireData() method did not mark the session as dirty when there was expired data on it, so if nothing else changed, the data was never actually purged. It was done like this by design, but in practice, it seems like sessions aren't modified as often, meaning they end up growing a lot with each state array that's stored on them, and expired data is never removed. We now check for expired data in the save() method (which is run every time a session is destroyed, if not manually) and if there is any, we mark the session as dirty, so that it is actually updated in the backend. Most of the time this will be transparent and have no visible performance hit, as it'll be run after the response is sent, during shutdown.

This closes #1053

Run Details

4359 of 12422 relevant lines covered (35.09%)

4.2 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4534.1 (COMMAND="install")	04 Sep 2019 02:13PM UTC	0	35.09	Travis Job 4534.1
6	4534.6 (COMMAND="update")	04 Sep 2019 02:16PM UTC	0	35.09	Travis Job 4534.6

Source Files on build 4534

Detailed source file information is not available for this build.

simplesamlphp / simplesamlphp / 4534
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4534

simplesamlphp / simplesamlphp / 4534 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4534

simplesamlphp / simplesamlphp / 4534
81%

README BADGES
x