spesmilo / electrum / 8883

63%

push

travis-ci

network: handle main_taskgroup dying better. passthrough CancelledError

Previously if a task running in the main_taskgroup raised,
main_taskgroup might have never finished as fx.run (another task running
in main_taskgroup) could not be cancelled (it was swallowing the CancelledError).

Need to be careful with catching all Exceptions or BaseExceptions,
as that might result in a coroutine not being cancellable.
Note that from python 3.8 onwards, CancelledError will inherit from BaseException
instead of Exception, so catching all Exceptions is somewhat less horrible
but this will only really matter if we raise the min py version to 3.8...

Really, all "except BaseException" lines are suspect and at least should be
considered for replacement with "except Exception".

-----

regarding fx.run not being cancellable before, and relevant lines, see:

https://github.com/spesmilo/electrum/blob/<a class=hub.com/spesmilo/electrum/commit/<a class="double-link" href="https://git"><a class=hub.com/spesmilo/electrum/commit/<a class="double-link" href="https://git"><a class=hub.com/spesmilo/electrum/commit/<a class="double-link" href="https://git"><a class=hub.com/spesmilo/electrum/commit/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253">6197cfbb3<a href="https://github.com/spesmilo/electrum/commit/9e57a5961554a8c550868127f0a10d72327da4b8">/electrum/network.py#L1171
https://github.com/kyuupichan/aiorpcX/blob/<a class="double-link" href="https://github.com/spesmilo/electrum/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/spesmilo/electrum/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/spesmilo/electrum/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/spesmilo/electrum/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/spesmilo/electrum/commit/0decdffce20aec217e9b4506ea20a0919994cea0">0decdffce</a>/aiorpcx/curio.py#L242
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L199
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L208
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L218
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L221
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L194
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L203
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L507
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L79

10298 of 19045 relevant lines covered (54.07%)

1.08 hits per line