optimizely / javascript-sdk / 1089

78%

push

travis-ci

fix(event processor): Stop accepting events after stop is called (#355)

Summary:

Before this change, event processor would continue processing user events after its stop method was called. If the batch size limit was reached after stop was called, it would dispatch a log event as normal. Worse, the internal queue wasn't being emptied when stop was called, which could lead to the same user event being included in two different log events.

With this change, the event processor's internal queue stops accepting events after the event processor is stopped. A warning message is logged, but the event is dropped.

Test plan:

Updated unit tests. Will manually test upon integration of a new version in optimizely-sdk.

593 of 649 branches covered (91.37%)

Branch coverage included in aggregate %.

6273 of 6386 relevant lines covered (98.23%)

108.22 hits per line