11113
66%

Ran 29 Aug 2019 05:59AM UTC

Jobs 1

Files 103

Run time 21s

Badge

Embed ▾

Committed 28 Aug 2019 07:47PM UTC coverage: 61.658%. Remained the same

Build # 11113

Build Type

cron

travis-ci

Committed by

web-flow

Commit Message

va: clean up DNS error handling for HTTP-01 challenges. (#4409)

This PR changes the VA to return `dns` problem type for errors when performing
HTTP-01 challenges for domains that have no IP addresses, or errors looking up
the IP addresses.

The `va.getAddrs` function is internal to the VA and can return
`berrors.BoulderError`s with a DNS type when there is an error, allowing the
calling code to convert this to a problem when required
using an updated `detailedError` function. This avoids some clunky conversion
the HTTP-01 code was doing that misrepresented DNS level errors as connection
problems with a DNS detail message.

In order to add an integration test for challenge validation that results in
`getAddrs` DNS level errors the Boulder tools image had to be bumped to a tag
that includes the latest `pebble-challtestsrv` that
supports mocking SERVFAILs. It isn't possible to mock this case with internal IP
addresses because our VA test configuration does not filter internal addresses
to support the testing context.

Additionally this branch removes the `UnknownHostProblem` from the `probs`
package:

1. It isn't used anywhere after 532c210
2. It's not a real RFC 8555 problem type. We should/do use the
   DNS type for this.

Resolves https://github.com/letsencrypt/boulder/issues/4407

Run Details

11538 of 18713 relevant lines covered (61.66%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
7	11113.7 (RUN="coverage" CONTAINER="netaccess")	29 Aug 2019 05:58AM UTC	0	61.66	Travis Job 11113.7

Source Files on build 11113

Detailed source file information is not available for this build.

letsencrypt / boulder / 11113
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11113

letsencrypt / boulder / 11113 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11113

letsencrypt / boulder / 11113
66%

README BADGES
x