vaadin / vaadin-overlay / 1503

95%

push

travis-ci

<a href="https://github.com/vaadin/vaadin-overlay/commit/<a class=hub.com/vaadin/vaadin-overlay/commit/<a class="double-link" href="https://git"><a class=hub.com/vaadin/vaadin-overlay/commit/<a class="double-link" href="https://git"><a class=hub.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b">936effd6f<a href="https://github.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b">&lt;a href=&quot;https://github.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b&amp;quot;&amp;gt;&amp;amp;quot;&amp;gt;attach shadowRoot when needed (#157)

* attach shadowRoot when needed

* don&amp;amp;#39;t re-attach shadowroot, but wait for defined

* append instance synchronously when possible

* Revert &amp;amp;quot;append instance synchronously when possible&amp;amp;quot;

This reverts commit &amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/vaadin/vaadin-overlay/commit/&amp;lt;a class=&amp;quot;double-link&quot; href=&quot;https://github.com/vaadin/vaadin-overlay/commit/d25a33c8d387eb3d195e4cb3b8676d9aba5f3f7f&quot;&gt;d25a33c8d&lt;/a&gt;&quot;&gt;d25a33c8d&lt;/a&gt;&lt;a href=&quot;https://github.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b&quot;&gt;.

Revert &amp;quot;don&amp;#39;t re-attach shadowroot, but wait for defined&amp;quot;

This reverts commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/vaadin/vaadin-overlay/commit/<a class="double-link" href="https://github.com/vaadin/vaadin-overlay/commit/742ca6972d64f39ce8765515d4433218d35f231c">742ca6972</a>">742ca6972</a><a href="https://github.com/vaadin/vaadin-overlay/commit/936effd6f688595839241708406c840a5ad0ad9b">.

Revert &quot;attach shadowRoot when needed&quot;

This reverts commit </a><a class="double-link" href="https://github.com/vaadin/vaadin-overlay/commit/<a class="double-link" href="https://github.com/vaadin/vaadin-overlay/commit/5ca0c5b17f9ea4062a1aecabf601f994ce72e3dd">5ca0c5b17">5ca0c5b17.

* use constructor instead of connectedCallback

* add missing super call

* Fix typo

* move styleElement back to connectedCallback

176 of 201 branches covered (87.56%)

Branch coverage included in aggregate %.

270 of 293 relevant lines covered (92.15%)

1213.51 hits per line