343
63%
master: 69%

Ran 28 Aug 2019 03:49AM UTC

Jobs 7

Files 270

Run time 12min

Badge

Embed ▾

pending completion

Build # 343

Build Type

push

travis-ci

Committed by

rtobar

Commit Message

Preventing TypeError during date comparison

The type of lastSchedule up to this point is either NoneType or str,
but on the other hand lastDelivery is a float (the type we use
internally to hold date/times). These two values are compared for order,
and while python2 happily compares strings v/s floats, python3 refuses
to do so and bombs out with a TypeError.

Because the subscription code is so convolved, it's a bit difficult to
fix this at the very source of the problem, but ensuring the correct
data representation just before the comparison is sufficient.

This problem was obviously not caught by our unit test suite because the
conditions to trigger it were not coded into any of them. I'm thus
adding a new unit test that reproduces the original problem, and that
will ensure this doesn't happen again.

This patch solves #6.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

19406 of 30656 relevant lines covered (63.3%)

2.66 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	343.1 (DB=sqlite3)	28 Aug 2019 03:49AM UTC	162	64.16	Travis Job 343.1
2	343.2 (DB=mysql)	28 Aug 2019 03:51AM UTC	162	64.19	Travis Job 343.2
3	343.3 (DB=postgresql)	28 Aug 2019 03:50AM UTC	162	64.19	Travis Job 343.3
4	343.4	28 Aug 2019 04:01AM UTC	162	64.08	Travis Job 343.4
5	343.5	28 Aug 2019 03:49AM UTC	162	64.18	Travis Job 343.5
6	343.6	28 Aug 2019 04:00AM UTC	162	64.23	Travis Job 343.6
7	343.7	28 Aug 2019 04:00AM UTC	162	64.21	Travis Job 343.7

ICRAR / ngas / 343
63%
master: 69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 343

ICRAR / ngas / 343 63% master: 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 343

ICRAR / ngas / 343
63%
master: 69%

README BADGES
x