342
69%

Ran 28 Aug 2019 01:42AM UTC

Jobs 7

Files 160

Run time 47min

Badge

Embed ▾

pending completion

Build # 342

Build Type

push

travis-ci

Committed by

rtobar

Commit Message

Preventing TypeError during date comparison

The type of lastSchedule up to this point is either NoneType or str,
but on the other hand lastDelivery is a float (the type we use
internally to hold date/times). These two values are compared for order,
and while python2 happily compares strings v/s floats, python3 refuses
to do so and bombs out with a TypeError.

Because the subscription code is so convolved, it's a bit difficult to
fix this at the very source of the problem, but ensuring the correct
data representation just before the comparison is sufficient.

This problem was obviously not caught by our unit test suite because the
conditions to trigger it were not coded into any of them. I'm thus
adding a new unit test that reproduces the original problem, and that
will ensure this doesn't happen again.

This patch solves #4.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

12906 of 19173 relevant lines covered (67.31%)

4.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	342.1 (DB=sqlite3)	28 Aug 2019 01:42AM UTC	67.0	Travis Job 342.1
2	342.2 (DB=mysql)	28 Aug 2019 01:43AM UTC	67.01	Travis Job 342.2
3	342.3 (DB=postgresql)	28 Aug 2019 01:43AM UTC	67.1	Travis Job 342.3
4	342.4	28 Aug 2019 02:29AM UTC	67.03	Travis Job 342.4
5	342.5	28 Aug 2019 01:42AM UTC	67.03	Travis Job 342.5
6	342.6	28 Aug 2019 01:52AM UTC	67.12	Travis Job 342.6
7	342.7	28 Aug 2019 01:52AM UTC	67.05	Travis Job 342.7

Source Files on build 342

Detailed source file information is not available for this build.

ICRAR / ngas / 342
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 342

ICRAR / ngas / 342 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 342

ICRAR / ngas / 342
69%

README BADGES
x