cilium / cilium / 10381

39%

push

travis-ci-com

endpoint: do not access endpoint mutex within EndpointManager

The order of locking is important between `Endpoint` and `EndpointManager`.
The `Endpoint` must have its mutex acquired before accessing the
`EndpointManager`, as its fields are accessed / modified depending on the
operation performed. If locking was done in the opposite order, one `Endpoint`
mutex being held would block out all operations on the` EndpointManager`, which
is not desirable, since it is accessed frequently. Previously, `EndpointManager`
functions themselves had to lock the `Endpoint`. Leaking the locking internals
of an `Endpoint`, though, means that callers have to ensure that access to
`Endpoint` is performed correctly, which leaks implementation. In order to
maintain the same locking ordering as before, reverse the receiver / parameter
w.r.t. insertion and deletion of `Endpoint` from the `EndpointManager`. Now, an
`Endpoint` acquires its mutex before performing an operation on an
`EndpointManager` instead of the `EndpointManager` having to be aware of the
mutex of the `Endpoint`. As a result, exposure of `Endpoint` identifiers, like
`ContainerID`, `DockerEndpointID`, etc., is dramatically reduced.

Signed-off by: Ian Vernon <ian@cilium.io>

128 of 128 new or added lines in 6 files covered. (100.0%)

25515 of 57897 relevant lines covered (44.07%)

1169.27 hits per line