• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

cilium / cilium / 10381
39%

Build:
DEFAULT BRANCH: master
Ran 27 Aug 2019 09:59AM UTC
Jobs 1
Files 439
Run time 53s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

27 Aug 2019 09:39AM UTC coverage: 44.07% (+0.05%) from 44.022%
10381

push

travis-ci-com

tgraf
endpoint: do not access endpoint mutex within EndpointManager

The order of locking is important between `Endpoint` and `EndpointManager`.
The `Endpoint` must have its mutex acquired before accessing the
`EndpointManager`, as its fields are accessed / modified depending on the
operation performed. If locking was done in the opposite order, one `Endpoint`
mutex being held would block out all operations on the` EndpointManager`, which
is not desirable, since it is accessed frequently. Previously, `EndpointManager`
functions themselves had to lock the `Endpoint`. Leaking the locking internals
of an `Endpoint`, though, means that callers have to ensure that access to
`Endpoint` is performed correctly, which leaks implementation. In order to
maintain the same locking ordering as before, reverse the receiver / parameter
w.r.t. insertion and deletion of `Endpoint` from the `EndpointManager`. Now, an
`Endpoint` acquires its mutex before performing an operation on an
`EndpointManager` instead of the `EndpointManager` having to be aware of the
mutex of the `Endpoint`. As a result, exposure of `Endpoint` identifiers, like
`ContainerID`, `DockerEndpointID`, etc., is dramatically reduced.

Signed-off by: Ian Vernon <ian@cilium.io>

128 of 128 new or added lines in 6 files covered. (100.0%)

25515 of 57897 relevant lines covered (44.07%)

1169.27 hits per line

Jobs
ID Job ID Ran Files Coverage
1 10381.1 27 Aug 2019 09:59AM UTC 0
44.07
Travis Job 10381.1
Source Files on build 10381
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #10381
  • c703ce75 on github
  • Prev Build on master (#10380)
  • Next Build on master (#10384)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc