inveniosoftware / invenio-base / 544

96%

master: 97%

Pull #145

travis-ci

wsgi: make proxy fix fully configurable

* The general problem solved here: whenever we need to take into
  any of the following headers set by a proxy: `X-Forwarded-For`,
  `X-Forwarded-Proto`, `X-Forwarded-Host`, `X-Forwarded-Port`,
  or `X-Forwarded-Prefix` we can fine tune it with the new
  configuration variable (see docstring for more info).

* The concrete problem solved here: when Invenio is running
  behind a proxy which does SSL termination, the
  `X-Forwarded-Proto` header is ignored causing the Flask
  application to generate URLs with the wrong HTTP scheme.
  With this change the `x_proto` parameter can be configured
  so the header is taken into account and `url_for` generates
  the correct URLs.

  Before, having one proxy in front of the app that would send
  `X-Forwarded-Proto: https`, would make the Flask app generate
  http://hostname/some/view when calling `url_for(some.view)`,
  now setting the config `BASE_PROXYFIX_CONFIG = {x_proto: 1}`
  would correctly generate https://hostname/some/view when calling
  `url_for`.

6 of 6 new or added lines in 1 file covered. (100.0%)

185 of 192 relevant lines covered (96.35%)

2.89 hits per line