mcollina / aedes / 295

98%

push

travis-ci

Optimize Connect handler (#301)

* Set keepalive after auth, save mem if auth fails

* Enhance & Optimize connect handler
- For https://github.com/mcollina/aedes/pull/260/commits/06fc8392a, raise an "invalid protocol" callback error if there is

- aedes unsupported mqtt version: CONNACK return Code = 1
- client id length > 23 [MQTT 3.1.0 only]: CONNACK return Code = 2

- Added preConnect handler in handleConnect between earliest connect checks and normal checks. This is useful for users if they want to do some earilest DDoS check before server send any responses back, in this phrase connected=false

- Emit `connackSent` event and set connactSent=true if CONNACK is sent, not only after `client` event but also when normal connect checks phrase if necessary

- Added packet arguments in `connackSent` event

- set clientID to 'aedes_' + shortid() if empty [MQTT 3.1.1], it is better to keep it within 23 chars for better compatibility

- Emit `clientReady` event after we send back all offline messages to client

- Optimize negate function

- Optimize doConnack function and we could re-use it

- Set keepalive after authentication, save some resoures if there are plenty of failed authentication

* Clear connect timer earilest, performance-wise

* Refactored

* Drop useless comments

* Removed unused done arguments

* Added preConnect doc in README.md

* Used connect callback/event in unit tests

* Make preConnect() having a callback

* Fixed preConnect unit test

* Split return in favour of V8 optimization

273 of 293 branches covered (93.17%)

711 of 727 relevant lines covered (97.8%)

6701.65 hits per line