aiidateam / aiida-core / 6930
70%

DEFAULT BRANCH: develop
Ran
Jobs 4
Files 405
Run time 81min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6930

push

travis-ci

CasperWA 
Fix eagerness of `verdi setup --help` being overruled (#3257)

The eagerness of the `--help` option for the `verdi setup` and `verdi
quicksetup` commands was being overruled by the `--profile` option. This
is because the latter was also made eager, such that `verdi setup --help`
actually prompted for the profile name instead of showing the help.

The profile option was made eager in an attempt to solve another problem
where some of the other options of the command have contextual defaults
that depend on the value of the profile. It therefore needs to be parsed
first. In `click` the parse order is determined by the order in which
the options are defined on the command, regardless of the order in which
they are passed by the user. This was done correctly, but still the
contextual default of, for example the `--repository` option, was called
before the `--profile` was parsed, if the former was passed first. This,
however, was due to the fact that for the repository option, both the
`callback` as well as the `contextual_default` were defined, where the
former was inherited from the base option for the `verdi quicksetup`
command.

The final solution then is to remove the `callback` from the `--profile`
option for `verdi setup` and only have the `contextual_default`. This
will make sure that `--profile` will be parsed before the prompt loop
will be entered and the `contextual_default` will be called.

24445 of 32651 relevant lines covered (74.87%)

2.76 hits per line

Jobs
ID Job ID Ran Files Coverage
5 6930.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 0
68.65
 Travis Job 6930.5
6 6930.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 0
68.6
 Travis Job 6930.6
7 6930.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 0
69.6
 Travis Job 6930.7
8 6930.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 0
69.52
 Travis Job 6930.8
Source Files on build 6930
Detailed source file information is not available for this build.