MycroftAI / mycroft-core / 7307
50%

DEFAULT BRANCH: dev
Ran
Jobs 4
Files 126
Run time 49s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
7307

push

travis-ci

forslund 
Refactor skill manager (#2237)

Split skill_manager into three separate classes, SkillManager, SkillUpdater and SkillLoader splitting the responsibility into logical units

* Split the SkillManager.__init__ code to determine the download times into a new method
* Make docstrings consistent and PEP257 compliant.  Also fixed a couple of spelling errors
* fixed two issues introduced in the previous refactoring
* removed unnecessary assignment of an instance attribute to a local variable
* updated the unit test to mock out code that reaches outside of core, like MSM and the configuration manager.
* add several unittests and refactored load_priority method.
* add a test for the _get_last_modified_date function.
* add "quick" argument to docstring
* removed unused import
* new class containing the logic to periodically update/install skills and send skill manifests to the backend.
* import MsmException from where it is defined, not from the skill manager.
* add some logging to the skill updater
* remove code now in SkillUpdater from SkillManager
* added imports to __init__.py to define the API into the message bus package
* new base class for unit tests and module for reusable mocks
* new skill loader class that will replace the _load_or_reload_skill() method in the SkillManager class.
* moved skill loading logic from core.py into skill_loader.py, resulting in some refactoring of skill loader and skill manager.  change unit tests to match.
* added back some spacing that was inadvertently removed.
* change skill tester to use new SkillLoader class.
* Separate reload required check from performing reload to make logic easier
to follow
* Track skills that failed to load to handle infinite loop at first load
if skill fails to load
* Allow reloading skills that has failed to load
* Simplify first load of skills
- create activate, deactivate and unload methods for skill_loader
objects
- add sanity checks before activating and deactiva... (continued)

9084 of 17135 relevant lines covered (53.01%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 7307.1 (IS_TRAVIS=true) 0
53.01
 Travis Job 7307.1
2 7307.2 (IS_TRAVIS=true) 0
53.01
 Travis Job 7307.2
3 7307.3 (IS_TRAVIS=true) 0
53.01
 Travis Job 7307.3
4 7307.4 (IS_TRAVIS=true) 0
53.01
 Travis Job 7307.4
Source Files on build 7307
Detailed source file information is not available for this build.