cucumber / cucumber-jvm / 3218

86%

push

travis-ci

Merge pull request #1738 from cucumber/fix-hook-order

While the order in which hooks are added to the glue is undefined there
is the assumption that they are never the less reversed in order. So
given two methods both annotated with a before- and after hook, they
should be executed like so:

 - method a as a before hook
 - method b as a before hook
 - method b as a after hook
 - method a as a after hook

This failed to happen because Cucumber sorts hooks by order. This means
that before hooks with lower order are executed before hooks with a
higher order - and in reverse for after hooks. However because sort
preserves insertion order we ended up with this execution pattern:

 - method a as a before hook
 - method b as a before hook
 - method a as a after hook
 - method b as a after hook

17 of 17 new or added lines in 2 files covered. (100.0%)

5395 of 6183 relevant lines covered (87.26%)

0.87 hits per line