14
65%

Ran 17 Aug 2019 08:42PM UTC

Jobs 1

Files 5

Run time 1s

Badge

Embed ▾

pending completion

Build # 14

Build Type

push

travis-ci

Committed by

jstasiak

Commit Message

Simplify the generic load/save methods

Ok, so, I know what was wrong here. With a method signature like this:

    pub fn load<T: io::Read>(reader: &mut T)

I had to pass &mut &[u8] to load in order for the thing to work
correctly, because io::Read is implemented for &[u8] and I was adding
&mut on top of that in the reader parameter type – unnecessarily. Once I
removed that everything has fallen into place.

In the most problematic place once I removed &mut from &mut &*data what
was left was &*data and that's just converting a Vec to a reference to
a slice and this can be done more ergonomically.

Run Details

108 of 152 relevant lines covered (71.05%)

0.76 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	14.1	17 Aug 2019 08:42PM UTC	0	71.05	Travis Job 14.1

Source Files on build 14

Detailed source file information is not available for this build.

jstasiak / openpol / 14
65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14

jstasiak / openpol / 14 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14

jstasiak / openpol / 14
65%

README BADGES
x