firebase / firebase-js-sdk / 8769

0%

push

travis-ci

Enable strictPropertyInitialization for Firestore (#2078)

* Enable strictPropertyInitialization: Refactor Path to BasePath<T> similar to Android.

This avoids having uninitialized properties due to the init() method doing the construction.

* Remove dummy FirebaseConfig class.

This class doesn't exist on other platforms and was responsible for a bunch of
strict-property-initialization violations.

* Initialize _dataConverter in constructor.

Fixes a strict-property-initialization violation.

* Fix or suppress uninitialized properties in IndexedDbPersistence.

* Fix StreamBridge property types to correctly indicate they can be undefined.

* Make sure abstract class members are marked abstract so they don't need to be initialized.

* FieldValue.typeOrder
* Mutation.type / key / precondition
* PersistenceTransaction.currentSequenceNumber

* Fix uninitialized LLRBEmptyNode properties.

Throw errors instead of potentially returning undefined.

I ran the SortedMap perf tests before/after this change and there was no discernible difference.

* Fix uninitialized properties in MemoryPersistence.

* Fix misc. uninitialized properties.

* Suppress some intentionally uninitialized properties.

These would be obnoxious to define as `| undefined` but we also can't initialize them in the constructor.

* Fix some misc. uninitialized properties in tests.

* Suppress some intentionally uninitialized properties in tests.

* Enable strictPropertyInitialization.

* Minor CR feedback.

6320 of 7775 branches covered (81.29%)

Branch coverage included in aggregate %.

19473 of 21131 relevant lines covered (92.15%)

4269.9 hits per line