cilium / cilium / 9836
39%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 435
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 44.174% (+0.04%) from 44.139%
9836

push

travis-ci-com

tgraf 
aws/eni: Fix race condition leading to overaggressive ENI allocation

The state in EC2 is always considered the source of truth. For this reason, the
EC2 is queried regularly to fetch the latest state. This ensures that the
operator always recovers if it ever gets out of sync.

In order to keep ENI allocation efficient, the resync operation does not block
allocations. This means that allocations will happen while the resync is in
progress. The resync starts at T0 and ends at T1. If allocations happen between
T0 and T1, they may or may not be included in the list of ENIs returned by the
resync.

When an allocation succeeds, it declares the need for a resync to fetch the
latest state. So far, any resync that completes after the allocation has
completed was considered sufficient. However, if the resync started before the
allocation and completes afterwards it may not include the ENI that was
allocated  and thus mistakenly fulfills the resync requirement without
containing the relevant information. This can lead to too many allocations
occurring.

This commit fixes this by adding understanding of resync timestamps. It also
extends the unit tests to reproduce this problem and validate the fix.

Also, while doing this, it makes sense to add the ENI to the instances manager
based on the ENI information returned by the CreateNetworkInterface and
AttachNetworkInterface API calls. This makes the information available before
resync returns and the IPs can be made available earlier.

Signed-off-by: Thomas Graf <thomas@cilium.io>

25331 of 57344 relevant lines covered (44.17%)

1190.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9836.1 0
44.17
 Travis Job 9836.1
Source Files on build 9836
Detailed source file information is not available for this build.