CenterForOpenScience / waterbutler / 2790

92%

develop: 89%

Pull #379

travis-ci

add tests for chunked upload nonroot files

 * Improve the chunked upload tests for root-{upload,update}s. The
   previous tests were not very informative, testing only that the
   registered call was hit and that the data structure we told it to
   return was returned.

   * The returned data structure test is tautological and has been
     removed.  Remove unused fixtures from chunked upload test
     methods.  The response has been replaced with dummy data to
     emphasize this.

   * The has_call test has been updated to test that the data SENT to
     Box is correctly formed based off the rootedness and
     pre-existence of the target file.

 * Add tests for nonroot-{upload,update} following the example of
   root-*.

 * Sort keys when encoding the JSON payload for the chunked upload
   session endpoint.  Our test library will only check for naive
   equality when comparing data payloads, so it is important we define
   a canonical ordering for keys.

3 of 3 new or added lines in 1 file covered. (100.0%)

6640 of 7231 relevant lines covered (91.83%)

1.84 hits per line