9376
68%

Ran 06 Aug 2019 08:27PM UTC

Jobs 4

Files 244

Run time 28min

Badge

Embed ▾

pending completion

Build # 9376

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Allow services and workflows with the same path (#2692)


#2643 

We were calling WorkflowDAO.findByPath in several locations to see if an entry already existed. For example, when creating a service, we would call that method, and if there was a workflow with that path, the duplicate check would fire, and hence the bug.

Changed the method to return a List<Workflow> instead of a Workflow.
Then added a new Workflow WorkflowDAO.findByPath method that takes a class as a third parameter and only returns 1 result.
Replaced all compilation errors introduced by method 1 with calls to method 2.

Also separated out the service endpoints into ServiceResource.java. Made AbstractWorkfowResource as a base class for ServiceResource and WorkflowResource to hold shared functionality.

Finally, removed DiscriminatorValue annotations.
They're not used unless you also have the DiscriminatorColumn
annotation, which we don't, and led to some confusion on
my part when I first started looking at the code.

Coverage Stats

7615 of 15936 relevant lines covered (47.78%)

1.29 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	9376.2 (TESTING_PROFILE=unit-tests)	06 Aug 2019 08:27PM UTC	12.15	Travis Job 9376.2
3	9376.3 (TESTING_PROFILE=integration-tests)	06 Aug 2019 08:48PM UTC	12.4	Travis Job 9376.3
4	9376.4 (TESTING_PROFILE=tool-integration-tests)	06 Aug 2019 08:41PM UTC	40.68	Travis Job 9376.4
5	9376.5 (TESTING_PROFILE=workflow-integration-tests)	06 Aug 2019 08:49PM UTC	40.81	Travis Job 9376.5

Source Files on build 9376

Detailed source file information is not available for this build.

dockstore / dockstore / 9376
68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9376

dockstore / dockstore / 9376 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9376

dockstore / dockstore / 9376
68%

README BADGES
x