sonata-project
/
SonataMediaBundle
/
3815
51%
|
Ran
|
Jobs
8
|
Files
137
|
Run time
37min
|
Badge
Embed ▾
README BADGES
|
cron
travis-ci
core23Fixed deletion of images with id greater than 1000 (#1592) * Fixed deletion of images with id greater than 1000 Inside the $this->getReferenceImage() method, the id of the $media object is used, but at the time of the postRemove event, the $media object is detached from an EntityManager and its id is null. During the postRemove event, the $media->getId() method returns null, and the $this->getReferenceImage() method returns the wrong path and the file remains in the file system as garbage. My changes fix this. * Add testPostRemove(). Test for "Fix deletion of images with id greater than 1000". * Update testPostRemove(). * The visibility of the property "clones" is changed to private. * Adapted test "testPostRemove" to check the data in the private property "clones" instead of the protected. * Update src/Provider/BaseProvider.php Co-Authored-By: Javier Spagnoletti <phansys@gmail.com> * Update src/Provider/BaseProvider.php Co-Authored-By: Javier Spagnoletti <phansys@gmail.com> * Update tests/Provider/BaseProviderTest.php Co-Authored-By: Javier Spagnoletti <phansys@gmail.com> * Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me. * Revert "Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me." This reverts commit bab31c8e3. * Adding a separate version of the testPostRemove(), which can be run in the current branch 3, and in the proposed me. * Remove unnecessary comment. * Removed unnecessary comment * Reorganization of tests for compliance with the requirements. * Update tests/Provider/BaseProviderTest.php Co-Authored-By: Javier Spagnoletti <phansys@gmail.com> * Fixes for FlintCI. * Fixed deletion of images with id greater than 1000 Inside the $this->getReferenceImage() method, the id of the $media object is used, but at the ti... (continued)
2162 of 4214 relevant lines covered (51.31%)
33.55 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 3815.1 | 0 |
51.43 |
Travis Job 3815.1 | |
| 2 | 3815.2 | 0 |
51.4 |
Travis Job 3815.2 | |
| 3 | 3815.3 | 0 |
51.21 |
Travis Job 3815.3 | |
| 7 | 3815.7 (SYMFONY=3.4.*) | 0 |
51.21 |
Travis Job 3815.7 | |
| 8 | 3815.8 (DOCTRINE_ODM=1.*) | 0 |
51.21 |
Travis Job 3815.8 | |
| 9 | 3815.9 (SONATA_CORE=3.*) | 0 |
51.21 |
Travis Job 3815.9 | |
| 10 | 3815.10 (SONATA_ADMIN=3.*) | 0 |
51.21 |
Travis Job 3815.10 | |
| 13 | 3815.13 (DOCTRINE_ODM='dev-master as 1.x-dev') | 0 |
51.21 |
Travis Job 3815.13 |
Source Files on build 3815
Detailed source file information is not available for this build.