B4nan / mikro-orm / 541

100%

master: 100%

Build Type

push

travis-ci-com

Committed by Martin Adamek

Commit Message

feat(core): use knex to generate sql + enable connection pooling [BC]

QueryBuilder now internally uses knex to run all queries. As knex already supports connection pooling, thbis feature comes without any effort. New configuration for pooling is now availableAs knex already supports connection pooling, this feature comes without any effort.

BREAKING CHANGES:
Transactions now require using EM.transactional() method, previous helpers `beginTransaction/commit/rollback` are now removed. All transaction management has been removed from IDatabaseDriver interface, now EM handles this, passing the transaction context (carried by EM, and created by Connection) to all driver methods. New methods on EM exists: `isInTransaction` and `getTransactionContext`.
Because of knex being used as a query runner, there are some minor differences in results of plain sql calls (made by calling connection.execute() with string sql parameter instead of using QueryBuilder). Another difference is in postgre driver, that used to require passing parameters as indexed dollar sign ($1, $2, ...), while now knex requires the placeholder to be simple question mark (?), like in other dialects, so this is now unified with other drivers.

Closes #64

Run Details

1460 of 1460 branches covered (100.0%)

Branch coverage included in aggregate %.

324 of 324 new or added lines in 22 files covered. (100.0%)

2655 of 2655 relevant lines covered (100.0%)

4081.79 hits per line