chrisjsewell / aiida-crystal17 / 624

87%

master: 89%

push

travis-ci

<a href="https://github.com/chrisjsewell/aiida-crystal17/commit/<a class=hub.com/chrisjsewell/aiida-crystal17/commit/42a180dcacfa5bdb75286daf384e943bcc25acd9">42a180dca<a href="https://github.com/chrisjsewell/aiida-crystal17/commit/42a180dcacfa5bdb75286daf384e943bcc25acd9">&quot;&gt;`BaseRestartWorkChain`: allow handlers to override exit status

Mirrors aiidateam/aiida-quantumespresso commit </a><a class="double-link" href="https://github.com/chrisjsewell/aiida-crystal17/commit/<a class="double-link" href="https://github.com/chrisjsewell/aiida-crystal17/commit/35299616a03625fe899d63051f6a7c78dc53408e">35299616a</a>">35299616a</a><a href="https://github.com/chrisjsewell/aiida-crystal17/commit/42a180dcacfa5bdb75286daf384e943bcc25acd9">

Sometimes a calculation returns a non-zero exit code indicating it is
failed, but it can actually still be considered successful by the
workchain. In this case, the handler wants to override the exit code of
the calculation and return `ExitCode(0)` to indicate that the workchain
is successful despite the last calculation being failed. To facilitate
this the logic in the `BaseRestartWorkChain` is updated to detect zero
being returned by a handler.

In addition, to make this work, the default value of the `exit_code` for
an `ErrorHandlerReport` tuple needs to be `None` to be able to
distinguish when `ExitCode(0)` is purposefully returned.

6077 of 6948 relevant lines covered (87.46%)

2.62 hits per line