m-lab / ndt7-client-go / 101

89%

main: 88%

push

travis-ci-com

API CHANGE: NewClient(clientName, clientVersion) (#21)

* API CHANGE: NewClient(clientName, clientVersion)

This commit changes the NewClient API to take two arguments, the
clientName and the clientVersion, instead of a userAgent.

We didn't specify how userAgent was made. In theory we expected it
to be composed of `${clientName}/${clientVersion}` but that was not
enforced in any way. Per #16, we want the client to identify with
the server also using the query string.

This is for consistency with what the JavaScript client does.

While there, also provide information on the OS and the architecture
of the client, again as part of the query string.

Closes #16.

16 of 16 new or added lines in 2 files covered. (100.0%)

417 of 417 relevant lines covered (100.0%)

1.09 hits per line