codevise / pageflow / 2963

99%

master: 99%

Pull #1190

travis-ci

Support CDN that redirects to CDN

Previously, when using protocol relative URLs for paperclip and
zencoder attachments, HTTP was used as default protocol in social
share meta tag image URLs and when downloading thumbnails and posters
generated by Zencoder.

In both cases a redirect to HTTPS served by the CDN caused problems:

* Facebook does not appear to follow redirects and instead complains
  about invalid content type.

* `open-uri` which is used by Paperclip to perform the image download
  also does not follow redirects. Video Files stay in `encoding` state
  forever since `PollZencoderJob` assumes thumbnails are not there
  yet.

It should be safe to assume that the CDN supports HTTPS if protocol
relative URLs were configured in the first place. We therefore use
HTTPS as default protocol to solve the issue.

There is a third place that supplies HTTP as default protocol: URLs in
SMIL files used to have Akamai generate HLS files (see
`ZencoderVideoOutputDefinition`). Since the known Akamai setups using
this option do not redirect to HTTPS, the default protocol was left
unchanged to prevent regressions.

REDMINE-16967

3 of 3 new or added lines in 2 files covered. (100.0%)

16006 of 16119 relevant lines covered (99.3%)

59.48 hits per line