307
98%

Ran 22 Jul 2019 05:38PM UTC

Jobs 1

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 307

Build Type

Pull #238

travis-ci

Committed by

web-flow

Commit Message

Removed assertions that were hiding exceptions

The two assertions that were testing the sqlalchemy classes and instances
worked by catching and silencing exceptions. This could cause debugging
problems like:

https://github.com/graphql-python/graphene-sqlalchemy/issues/121
https://github.com/graphql-python/graphene-sqlalchemy/issues/122

on the other hand without them, if someone uses unmapped class/model it
would be trivial to diagnose the problem. So I believe we would be
better off without them.

Pull Request Pull Request #238: Removed assertions that were hiding exceptions

Run Details

Jobs

ID	Job ID	Ran	Files	Coverage
9	307.9 (TOXENV=pre-commit)	22 Jul 2019 05:38PM UTC	0		Travis Job 307.9

Source Files on build 307

Detailed source file information is not available for this build.

graphql-python / graphene-sqlalchemy / 307
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 307

graphql-python / graphene-sqlalchemy / 307 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 307

graphql-python / graphene-sqlalchemy / 307
98%

README BADGES
x