pvlib / pvlib-python / 2166
96%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 55
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2166

push

travis-ci

wholmgren 
refactor bifacial merge, improve merge tests (#747)

* Simplify merge method.

Simplify merge method by using list and dictionary comprehensions instead of
nested for loops. This also avoids the need to check if some of the elements
of the reports arguments are None, and the need to check if reports contains
more than one report. This should also be a small performance improvement.
This change also adds a bit more detail to the docstring for the merge method.
The creation of a new empty report is also modified to no longer use an
intermediary list of keys.

* Update what's new doc.

* Update whatsnew file syntax.

* Rename whatsnew file to change format to rst.

* Fix linting errors.

* Remove pandas and numpy version reqs

* Update v0.7.1.rst

* Revert "Update v0.7.1.rst"

This reverts commit d131657b1.

* Revert "Remove pandas and numpy version reqs"

This reverts commit 84d718949.

* Reword elements in merge() comprehension.

* Fix handling of None values in merge.

If one of the values in the reports argument that merge() takes is a None,
this is now properly handled by being dropped.

* Remove unnecessary checks in merge().

Returns merge method to its original state with two nested for loops, but without
the checks for the number of dictionaries in the reports argument, or the check
that each element in reports is a dictionary. Reports are only created in the build
method so a test was made to ensure that build always returns a dictionary instead.

* Add tests for merge() and build().

* Fix lint errors.

* Correct import mistake.

Previous commits I made did not import the PVFactorsReportBuilder
class correctly.

* Reinsert type check in merge loop.

* Revert "Reinsert type check in merge loop."

This reverts commit eeb80530c.

* Fix test_build_1 test.

* Update what's new file.

Add bullet ... (continued)

7142 of 7657 relevant lines covered (93.27%)

3.51 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2166.1 (CONDA_ENV=py35-min) 0
72.6
 Travis Job 2166.1
2 2166.2 (CONDA_ENV=py35) 0
92.9
 Travis Job 2166.2
3 2166.3 (CONDA_ENV=py36 TASK="coverage" DEPLOY_ENV="true") 0
92.9
 Travis Job 2166.3
4 2166.4 (CONDA_ENV=py37) 0
92.9
 Travis Job 2166.4
Source Files on build 2166
Detailed source file information is not available for this build.