sonata-project / SonataDoctrineORMAdminBundle / 2392
75%

DEFAULT BRANCH: 3.x
Ran
Jobs 7
Files 37
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2392

push

travis-ci

core23 
Resolve error in entities with composite ID

<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->

Solution for [#923](https://github.com/sonata-project/SonataDoctrineORMAdminBundle/issues/923).

This PR would fix the errors when generating URLs in Sonata Admin when using entities with composite and foreign keys. It also takes into account that ids can be binary, returning the correct value. See manual of doctrine: [Link](https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/tutorials/composite-primary-keys.html).
We rollback fix #876.

<!--
    Show us you choose the right branch.
    Different branches are used for different things :
    - 3.x is for everything backwards compatible, like patches, features and deprecation notices
    - master is for deprecation removals and other changes that cannot be done without a BC-break
    More details here: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/3.x/CONTRIBUTING.md#the-base-branch
-->

<!--
    Specify which issues will be fixed/closed.
    Remove it if this is not related.
-->

Closes #923. Revert #876.

<!-- MANDATORY
    Fill the changelog part inside the code block.
    Follow this schema: http://keepachangelog.com/
    This will end up on https://github.com/sonata-project/SonataDoctrineORMAdminBundle/releases,
    please keep it short and clear and to the point
-->
- Fix "Resolve string value of is with __toString cause trouble with composite key" (#923)
<!--
    If you are updating something that doesn't require
    a release, you can delete the whole Changelog section.
    (eg. update to docs, tests)
-->

945 of 1321 relevant lines covered (71.54%)

19.66 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2392.1 37
72.1
 Travis Job 2392.1
2 2392.2 37
71.49
 Travis Job 2392.2
3 2392.3 37
71.41
 Travis Job 2392.3
6 2392.6 (COMPOSER_FLAGS="--prefer-lowest") 37
72.1
 Travis Job 2392.6
7 2392.7 (SYMFONY=3.4.*) 37
71.41
 Travis Job 2392.7
8 2392.8 (SONATA_CORE=3.*) 37
71.41
 Travis Job 2392.8
9 2392.9 (SONATA_ADMIN=3.*) 37
71.41
 Travis Job 2392.9
Source Files on build 2392