6765
70%

Ran 19 Jul 2019 08:07AM UTC

Jobs 4

Files 404

Run time 10min

Badge

Embed ▾

pending completion

Build # 6765

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Make the `execmanager.submit_calculation` idempotent'ish (#3188)

The `submit_calculation` is responsible for submitting a job, that was
already uploaded to the remote machine, to the scheduler. There was a
risk of the daemon submitting the same job twice. If the first time
around it successfully submitted the job and set the job id as an
attribute on the node, but then was interrupted (for example due to a
shutdown) before it could transition the `CalcJob` to the `UPDATE`
transport task, once reloaded the command would be executed again. This
would not complain and simply submit the job again to the scheduler.
This is both a waste of resources and can cause various complications.

It is impossible to make the function fully idempotent, but by checking
if the job id attribute is already set for the node at the beginning and
returning it should minimize the risk of double submission.

Run Details

24301 of 32523 relevant lines covered (74.72%)

2.75 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	6765.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	19 Jul 2019 08:07AM UTC	68.43	Travis Job 6765.5
6	6765.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	19 Jul 2019 08:13AM UTC	68.39	Travis Job 6765.6
7	6765.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	19 Jul 2019 08:14AM UTC	69.37	Travis Job 6765.7
8	6765.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	19 Jul 2019 08:17AM UTC	69.29	Travis Job 6765.8

Source Files on build 6765

Detailed source file information is not available for this build.

aiidateam / aiida-core / 6765
70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6765

aiidateam / aiida-core / 6765 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6765

aiidateam / aiida-core / 6765
70%

README BADGES
x