trivago / gollum / 2006

71%

cron

travis-ci

Refactor formatters to use metadata as intermediate (#249)

* convert grokToJSON to grok to metadata
* remove collectd to influx formatter.
Resons:
- This formatter is too specific.
- A collectd consumer and an influxdb producer should handle this instead.
- There is other software doing this kind of work better than gollum (e.g. telegraph).

* remove extractToJSON.
Reason: This kind of functionality will be handled by formatters converting metadata to a specific output format like JSON.

* remove jsonToInflux. Same reason as collectdToInflux.
* convert jsonToArray to ToArray to match the new metadata concept.
* remove serialize formatter as spooling does not need it anymore.
* add a formater that can convert metadata to json
* remove filter.json go as it will be replaced by filter.metadata.
* rename 'ApplyTo' to 'Target'.
- includes renaming format.MetadataCopy to format.Copy.
- includes adding format.Move

As we now put more emphasis on metadata, 'target' becomes a much clearer identifier.
Along with this, the names for Set and Get functions have been simplified.
This should make formatter configurations more readable and easier to understand.

* use a better example for format.double
* add an option to keep the last separator
* finish format.ToJSON
* remove format.TextToJSON.

- Nobody understood the syntax anyways.
- format.Grok can handle most of its usecases.
- A high maintenance burden for a too small usecase.

* rename format.Clear to format.Delete
* remove unittest for texttojson
* rename format.Trim to format.Bounds.
There will be a new format.Trim that uses strings.Trim.

* add format.Trim
* rename format.Bounds to format.TrimToBounds
* introduce Source parameter to all SimpleFormatter.
- Also includes targeting a specific metadata key for parser formatter.

* add a metadata access function for parsers
* switch aggregate from Target to Source
* fix metadata being properly cloned on msg.Clone
* ad... (continued)

541 of 541 new or added lines in 35 files covered. (100.0%)

2703 of 3776 relevant lines covered (71.58%)

2340.36 hits per line