ethereumjs / ethereumjs-wallet / 116

89%

master: 85%

Pull #95

travis-ci

Convert salt to Buffer instance before encrypting

Previously, if a `salt` option was supplied as a string it would be passed to
`pbkdf2Sync`/`scrypt` as a string, but during decryption it was always
converted to a Buffer instance such that supplying a `salt` option as a string
resulted in output that could not be decrypted.

This commit fixes the bug, and also makes encrypted output match up with the
output of other wallet libraries, e.g.  `ethers`, whenever the equivalent
encryption options are used consistently across libraries.

See the following `web3.js` PRs: [#2950][2950] and [#2938][2938]

[2950]: https://github.com/ethereum/web3.js/pull/2950
[2938]: https://github.com/ethereum/web3.js/pull/2938

114 of 168 branches covered (67.86%)

256 of 287 relevant lines covered (89.2%)

85.08 hits per line