gap-system / gap / 10294

4%

Build Type

push

travis-ci

Committed by fingolfin

Commit Message

Restrict Size method for cyclic groups

This method needs to test whether a group element is the identity; but this
can lead to an infinite recursion if the input is an fp group, as then this
equality check may end up trying to compute the group size. This currently
actually happens when all packages are loaded (with only the default set of
filters, another Size method is selected for cyclic fp groups).

We fix this by adding the `CanEasilyCompareElements` filter to the argument
filters of the method. Strictly speaking, we'd also want to check for
something like `CanEasilyComputerElementOrder`, but that doesn't exist.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

283986 of 336791 relevant lines covered (84.32%)

23869421.03 hits per line