1770
66%

Ran 16 Jul 2019 12:57AM UTC

Jobs 1

Files 48

Run time 4s

Badge

Embed ▾

Committed 16 Jul 2019 12:55AM UTC coverage: 63.492% (+0.02%) from 63.477%

Build # 1770

Build Type

push

travis-ci

Committed by

willhug

Commit Message

go diff: Fix long-standing diffing bug

Summary: Noticed and brought up by Edwin last week. This bug has existed
for a long time.  The way it would manifest, is that when a field would
get replaced with a "Nil" value in the execution graph, instead of
diffing the value and returning "nil" as the new value, we were using
the result of a failed cast `newVal, ok :=
val.(map[string]interface{})`.
The `newVal` would be an empty map (instead of the "nil" value we really
wanted).  This would lead to weird behavior, where, on an update,
instead of returning a nil value for something like current driver, we'd
return an empty object instead.

Run Details

4233 of 6667 relevant lines covered (63.49%)

15181.33 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1770.1	16 Jul 2019 12:57AM UTC	0	63.49	Travis Job 1770.1

Source Files on build 1770

Detailed source file information is not available for this build.

samsarahq / thunder / 1770
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1770

samsarahq / thunder / 1770 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1770

samsarahq / thunder / 1770
66%

README BADGES
x