zalando-incubator / stackset-controller / 1000

50%

push

travis-ci

Improve error handling (#144)

* Add stacksetLogger()

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* Proceed with reconciliation if stack creation fails

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* Remove error from MarkExpiredStacks()

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* Get rid of trafficSwitchError

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* ReconcileStackSet: don't abort on most errors

Instead of just aborting on the first encountered error, try to proceed
and reconcile the remaining resources. The only thing that currently
causes a hard error is UpdateFromResources(), the rest should be logged,
reported as an event and ignored.

StackContainer logic has been adjusted to check other stack resources in
IsReady() as well to prevent a situation where traffic is directed to a
stack that can't be reconciled.

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* HPA: don't check status.observedGeneration

This apparently doesn't work at all for HPA resources for some reason.

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* Fix TypeMeta on the stackset _again_

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

* Add an e2e test for handling of broken stacks

Signed-off-by: Alexey Ermakov <alexey.ermakov@zalando.de>

90 of 90 new or added lines in 6 files covered. (100.0%)

1408 of 1810 relevant lines covered (77.79%)

11.83 hits per line