6697
70%

Ran 09 Jul 2019 02:21PM UTC

Jobs 4

Files 403

Run time 12min

Badge

Embed ▾

pending completion

Build # 6697

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Make the `execmanager.upload_calculation` idempotent'ish (#3146)

The `upload_calculation` would cause an exception if called multiple
times for the same calculation, which can happen if the first time that
the runner was working on it got interrupted, for example due to a
daemon shutdown. The reason is that the second time around the adding of
the `remote_folder` data node will raise a uniqueness exception,
because there can only be one output with the same label.

Note that full idem-potency is impossible, but this change should make
the problem a lot less likely to occur. The idea is to delay the actual
attaching of the remote folder data node to the last moment possible.
This way, if the method is called again and the folder is already there,
we can be reasonably sure that the files were already retrieved
successfully and we simply return, leaving the call a no-op. This is
done in the beginning of the function to check if the output node already
exists using the `LinkManager.first()` call. If the node exists, the
upload function has apparently already been called before and reached
the end of the function where it adds the remote folder. This means all
the files were already successfully uploaded so we can safely skip it.

Run Details

24182 of 32464 relevant lines covered (74.49%)

2.76 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	6697.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	09 Jul 2019 02:21PM UTC	68.17	Travis Job 6697.5
6	6697.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	09 Jul 2019 02:32PM UTC	68.11	Travis Job 6697.6
7	6697.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	09 Jul 2019 02:32PM UTC	69.73	Travis Job 6697.7
8	6697.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	09 Jul 2019 02:30PM UTC	69.68	Travis Job 6697.8

Source Files on build 6697

Detailed source file information is not available for this build.

aiidateam / aiida-core / 6697
70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6697

aiidateam / aiida-core / 6697 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6697

aiidateam / aiida-core / 6697
70%

README BADGES
x