tarantool / tarantool / 17747
83%
master: 88%

LAST BUILD BRANCH: gh_12830_alert_wo
DEFAULT BRANCH: master
Ran
Jobs 1
Files 305
Run time 31s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
17747

push

travis-ci

Totktonada 
<a href="https://github.com/tarantool/tarantool/commit/d690002a2">test: net.box: fix case re invalid msgpack warning

The test case has two problems that appear from time to time and lead to
flaky fails. Those fails are look as shown below in a test-run output.

 | Test failed! Result content mismatch:
 | --- box/net.box.result	Mon Jun 24 17:23:49 2019
 | +++ box/net.box.reject	Mon Jun 24 17:51:52 2019
 | @@ -1404,7 +1404,7 @@
 |  ...
 |  test_run:grep_log(&#39;default&#39;, &#39;ER_INVALID_MSGPACK.*&#39;)
 | ---
 | -- &#39;ER_INVALID_MSGPACK: Invalid MsgPack - packet body&#39;
 | +- &#39;ER_INVALID_MSGPACK: Invalid MsgPack - packet length&#39;
 | ...
 | -- gh-983 selecting a lot of data crashes the server or hangs the
 | -- connection

&#39;ER_INVALID_MSGPACK.*&#39; regexp should match &#39;ER_INVALID_MSGPACK: Invalid
MsgPack - packet body&#39; log message, but if it is not in a log file at a
time of grep_log() call (just don&#39;t flushed to the file yet) a message
produced by another test case can be matched (&#39;ER_INVALID_MSGPACK:
Invalid MsgPack - packet length&#39;). The fix here is to match the entire
message and check for the message periodically during several seconds
(use wait_log() instead of grep_log()).

Another problem is the race between writing a response to an iproto
socket on a server side and closing the socket on a client end. If
tarantool is unable to write a response, it does not produce the warning
re invalid msgpack, but shows &#39;broken pipe&#39; message instead. We need
first grep for the message in logs and only then close the socket on a
client. The similar problem (with another test case) is described in
[1].

[1]: https://github.com/tarantool/tarantool/issues/4273#issuecomment-508939695

Closes: #4311

(cherry picked from commit </a><a class="double-link" href="https://github.com/tarantool/tarantool/commit/0f9fdd721">0f9fdd721</a><a href="https://github.com/... (continued)

41589 of 50415 relevant lines covered (82.49%)

846012.21 hits per line

Jobs
ID Job ID Ran Files Coverage
4 17747.4 (TARGET=coverage) 0
82.49
 Travis Job 17747.4
Source Files on build 17747
Detailed source file information is not available for this build.