Ran
|
Jobs
1
|
Files
12
|
Run time
2s
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
<a href="https://github.com/nock/nock/commit/<a class=hub.com/nock/nock/commit/ad342220ada1fcf87e8c5989b08c6764745ea563">ad342220a<a href="https://github.com/nock/nock/commit/ad342220ada1fcf87e8c5989b08c6764745ea563">">fix: request.end accepted arguments (#1591) * Fix typo about wrapping request.end. I&#39;m making this change it&#39;s own commit so I have a place to comment the findings. Digging through Node git history, I found the change that created the breaking change in nock (ref nock PR 929). https://github.com/nodejs/node/commit/</a><a class="double-link" href="https://github.com/nock/nock/commit/<a class="double-link" href="https://github.com/nock/nock/commit/a10bdb51b18dfaad874f3702a1daea51ec2d4514">a10bdb51b</a>">a10bdb51b</a><a href="https://github.com/nock/nock/commit/ad342220ada1fcf87e8c5989b08c6764745ea563">#diff-286202fdbdd74ede6f5f5334b6176b5cL779 Before Node v8, `OutgoingMessage`, which is extended by `ClientRequest`, would literally do what it says in the docs if data was provided. It would call `this.write(data, encoding)`. This meant that nock could wrap only the `write` method when recording and gather all the chunks even if the last chunk was sent to `end`. But, the above changed that to call an internal function dual used by `end` and `write`. * fix: request.end accepted arguments. Fixes #1549 The method now correctly accepts all the permutations allowed. request.end(data, encoding, callback) request.end(data, callback) request.end(data, encoding) request.end(data) request.end(callback) request.end() And a few tests were added to ensure all cases are explicitly covered.
782 of 808 branches covered (96.78%)
Branch coverage included in aggregate %.
1472 of 1486 relevant lines covered (99.06%)
165.39 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
4 | 3393.4 | 12 |
98.26 |
Travis Job 3393.4 |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
---|