308
100%

Ran 04 Jul 2019 03:09PM UTC

Jobs 4

Files 25

Run time 16s

Badge

Embed ▾

pending completion

Build # 308

Build Type

push

travis-ci

Committed by

BenMorel

Commit Message

Cache Money::formatTo()'s NumberFormatter for improved performance

Calling formatTo() many times spends quite some time in NumberFormatter constructor, that performs I/O, according to the profiler.
Because we usually call formatTo() many times in a row for the same locale, we can get a ~2x speedup with this fix.

The best way to tackle this in the future would be to deprecate the formatTo() method and introduce a MoneyFormatter object, that would keep a local cache of all locale/scale pairs.

Run Details

427 of 427 relevant lines covered (100.0%)

125.91 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	308.1	04 Jul 2019 03:09PM UTC	100.0	Travis Job 308.1
2	308.2	04 Jul 2019 03:09PM UTC	100.0	Travis Job 308.2
3	308.3	04 Jul 2019 03:09PM UTC	100.0	Travis Job 308.3
4	308.4 (dependencies=lowest)	04 Jul 2019 03:09PM UTC	100.0	Travis Job 308.4

Source Files on build 308

Detailed source file information is not available for this build.

brick / money / 308
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 308

brick / money / 308 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 308

brick / money / 308
100%

README BADGES
x