teambition / rrule-go / 73

99%

Pull #31

travis-ci

Validating parameters to RFC 5545

Per the RFC, many fields have limits that were not being checked (except
Bysetpos, for whatever reason). This can result in user error not being caught
early and also prevents you from using this library to catch said errors.

As well, FREQ is required by the RFC and if it wasn't specified, we would badly
assume some default. For these bounds in the standard, see:
https://tools.ietf.org/html/rfc5545#section-3.3.10

Note: it turns out we don't handle leap seconds right (they're why seconds go to
60 and not 59). In fact, when I tried to write a test with `BYSECOND=60`, it
was an infinite loop. Not sure if the bounds should be restricted below the RFC
as a result (I mean, who would honestly use leap seconds in a RRule, anyway?).

50 of 50 new or added lines in 2 files covered. (100.0%)

1173 of 1181 relevant lines covered (99.32%)

10.85 hits per line