aiidateam / aiida_core / 6523
74%

DEFAULT BRANCH: develop
Ran
Jobs 4
Files 392
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
6523

push

travis-ci

web-flow 
Merge pull request #3090 from sphuber/django_jsonb

This merge request includes commits that address multiple issues:

The main purpose of this PR is to migrate the old EAV schema for node
attributes and extras for the Django backend. The change of the models
and the database migrations have been implemented in the first commit by
@szoupanos . But this change allowed to homogenize and streamline a lot
of the rest of the code, since now both backends use JSONB for node
attributes and extras. For example this now means that the attribute
cache mechanism, that allowed one to store attributes, before the node
itself was stored, can be removed. This cache is now in a sense
delegated to the database model, where the attributes and extras column
is represented as a dictionary. In addition, the restriction of only
being able to store extras after a node was stored could also be lifted.
To simplify and robustify the access of attributes and extras, the
`BackendNode` interface has been significantly improved and tested.

Then an unrelated commit was added to migrate old `state` attributes
from legacy `JobCalculations`. We decided to do this on this branch,
since the migration was made a lot easier after both backends used
JSONB, meaning the SQL used in the migration was identical for both
backends.

The final step was to add migrations for existing export archives to
account for the two database migrations added in this PR, while upping
the version number to `v0.6`. The migrations will find `state`
attributes of `CalcJobNodes` and migrate the data. Serialized datetime
strings in attributes are also updated to reattach the timezone
information, which was originally never included since everything was
first converted to UTC before converting.

23941 of 32376 relevant lines covered (73.95%)

2.74 hits per line

Jobs
ID Job ID Ran Files Coverage
5 6523.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 0
67.78
 Travis Job 6523.5
6 6523.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests") 0
67.73
 Travis Job 6523.6
7 6523.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 0
69.35
 Travis Job 6523.7
8 6523.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests") 0
69.28
 Travis Job 6523.8
Source Files on build 6523
Detailed source file information is not available for this build.