10764
66%

Ran 19 Jun 2019 09:48PM UTC

Jobs 1

Files 95

Run time 6s

Badge

Embed ▾

Committed 19 Jun 2019 09:36PM UTC coverage: 60.96%. Remained the same

Build # 10764

Build Type

push

travis-ci

Committed by

jsha

Commit Message

gRPC: allow nil ValidationRecords in FinalizeAuthz2 (#4270)

The SA `FinalizeAuthorization2` RPC is used with
`FinalizeAuthorizationRequest` objects that may have a nil
`ValidationRecords` field (notably for DNS-01 challenges that
failed). The RPC wrapper should not reject such messages as incomplete.

We don't typically unit test gRPC wrappers, and adding
an integration test for this will likely conflict with
https://github.com/letsencrypt/boulder/issues/4241 so I tested this
fix manually using Certbot and a local Boulder instance configured
with the authz2 feature flag.

Before applying the fix, failing a DNS-01 challenge left the
authorization stuck in pending state and Certbot would poll until
it gave up. On the server-side a 500 error matching what we observed
in staging is logged: > boulder-ra [AUDIT] Could not record updated
validation: err=[rpc error: code = Unknown desc = Incomplete gRPC
request message] regID=[xxx] authzID=[xxxx]

After applying the fix failing a DNS-01 challenge caused the associated
authorization to be marked invalid immediately. No 500 errors are
logged.

Resolves https://github.com/letsencrypt/boulder/issues/4269

Run Details

11383 of 18673 relevant lines covered (60.96%)

0.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
6	10764.6 (RUN="coverage" CONTAINER="netaccess")	19 Jun 2019 09:48PM UTC	0	60.96	Travis Job 10764.6

Source Files on build 10764

Detailed source file information is not available for this build.

letsencrypt / boulder / 10764
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10764

letsencrypt / boulder / 10764 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10764

letsencrypt / boulder / 10764
66%

README BADGES
x