salesforce / refocus / 9608

89%

push

travis-ci

Add more publish tests for real-time events (#1186)

* Add publish tests for sample real-time events
Fix bugs found while testing (!!!)

Use redis publishAsync and always call publishObject expecting a
promise to be returned.
In samples api controller, always call publish inside the promise chain.
Fix the sampleStoreTimeout so it publishes sample update.
Stop double-publishing sample delete events when an aspect is deleted.
In subject db model, always call publish inside the promise chain.

* Add publish tests for real-time events for botActions, botData

Fix bugs found while testing.

When deleting botData, explicitly add something to the "changedKeys"
array, otherwise the prepareToPublish fn determines that there's nothing
to publish, so we were not emitting an event.

* Mostly just scaffolding for publish tests for rooms

* fixes from comments
remove console.log from botActions test
add test for editing an aspect without modifying tags
add test for verifying sample events when deleting subject (not covered by subject publish tests)
when editing subject tags, we were just sending subj delete and add events, but no sample delete event - added that now, and added test for it

* fixes from comments
remove console.log from botActions test
add test for editing an aspect without modifying tags
add test for verifying sample events when deleting subject (not covered by subject publish tests)
when editing subject tags, we were just sending subj delete and add events, but no sample delete event - added that now, and added test for it
moved the publish from the sample timeout clock job to the function which actually implements the timeout for consistency and testability

2875 of 3667 branches covered (78.4%)

46 of 46 new or added lines in 6 files covered. (100.0%)

7735 of 8827 relevant lines covered (87.63%)

624.83 hits per line